remove one notify_unless call #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 18, 2019
src/join_handle.rs
Outdated
| // completed or closed just before registration so we need to check for that. | ||
| state = (*header).state.load(Ordering::Acquire); | ||
|
|
||
| // If the task has been closed, notify the awaiter and return `None`. |
There was a problem hiding this comment.
Can you also update this comment to reflect the change?
Co-Authored-By: Stjepan Glavina <stjepang@gmail.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header::awaitercan only be changed withHeader::swap_awaiter, which only be called in three places.swap_awaiter(None)in two places, and one in functionJoinHandle::pollat line 202. sinceJoinHandle::pollwill not called concurrently, at line 211 we can conclude thatHeader::awaitermust becx.waker()(set at line 202) orNone(set by other thread). so callnotify_unlesswill have no effects, and can be removed.