Skip to content

Implement FromStr for PathBuf #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2019
Merged

Implement FromStr for PathBuf #489

merged 1 commit into from
Nov 9, 2019

Conversation

jaysonsantos
Copy link
Contributor

@jaysonsantos jaysonsantos commented Nov 9, 2019 •
edited
Loading

This makes PathBuf compatible with std version as you can simply call:

let path: PathBuf = FromStr::from_str(s).unwrap()

@jaysonsantos
Implement FromStr for PathBuf
d8e52c1 
This makes PathBuf compatible with std version as you can simply call
let path: PathBuf = FromStr::from_str(s).unwrap()
yoshuawuyts
yoshuawuyts approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks heaps!

@yoshuawuyts
Copy link
Contributor

Reference from std: https://doc.rust-lang.org/src/std/path.rs.html#1542-1548

@yoshuawuyts yoshuawuyts merged commit 16565cc into async-rs:master Nov 9, 2019
@jaysonsantos jaysonsantos deleted the pathbuf-fromstr branch November 9, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaysonsantos @yoshuawuyts