Skip to content

Add Future::join and Future::try_join #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2019

Conversation

abhishekc-sharma
Copy link
Contributor

@abhishekc-sharma abhishekc-sharma commented Nov 8, 2019

Addresses #470 .

@yoshuawuyts Regarding the module level documentation changes, is the plan to replace join! and try_join! in the documentation with join and try_join ?

@ghost
Copy link

ghost commented Nov 8, 2019

I like this change. 👍

To be honest, I don't find join! and try_join! all that useful nor expect those macros to pop up in practice. It seems a lot of people are confused by future joining in general (see here).

Instead, I expect people will spawn futures to make them run in paralle/concurrently rather than joining futures.

wdyt, @yoshuawuyts?

@yoshuawuyts
Copy link
Contributor

@stjepang you might be right actually. Agree we can probably remove them without much loss.

@abhishekc-sharma abhishekc-sharma marked this pull request as ready for review November 9, 2019 08:04
@abhishekc-sharma
Copy link
Contributor Author

abhishekc-sharma commented Nov 9, 2019

I have changed the reference to join! and try_join! in the module documentation to refer to join and try_join functions instead.

@ghost
Copy link

ghost commented Nov 9, 2019

@yoshuawuyts @portgasd666 In that case, let's also remove macros join! and try_join! in this PR? :)

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yoshuawuyts yoshuawuyts merged commit 037119c into async-rs:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants