Skip to content

Refactor the networking driver #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Sep 12, 2019
Merged

Refactor the networking driver #188

merged 3 commits into from Sep 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2019

This is a big cleanup that simplifes the layer between mio and our networking driver. The Watcher API was pretty much entirely designed by @yoshuawuyts.

Fixes #185

@ghost ghost requested a review from yoshuawuyts September 12, 2019 16:48
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this turned out great! Very cool :D

@ghost
Copy link
Author

ghost commented Sep 12, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 12, 2019
188: Refactor the networking driver r=stjepang a=stjepang

This is a big cleanup that simplifes the layer between mio and our networking driver. The `Watcher` API was pretty much entirely designed by @yoshuawuyts.

Fixes #185 

Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 12, 2019

Build failed

  • continuous-integration/travis-ci/push

@ghost
Copy link
Author

ghost commented Sep 12, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 12, 2019
188: Refactor the networking driver r=stjepang a=stjepang

This is a big cleanup that simplifes the layer between mio and our networking driver. The `Watcher` API was pretty much entirely designed by @yoshuawuyts.

Fixes #185 

Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 12, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 2818c70 into async-rs:master Sep 12, 2019
@ghost ghost deleted the refactor-net-driver branch September 12, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deadlock on UnixStream pair with ends in separate threads
1 participant