Use Promise Spec Terminology Where Appropriate#38
Merged
ghengeveld merged 1 commit intoasync-library:masterfrom Mar 29, 2019
dhurlburtusa:patch-1
Merged
Use Promise Spec Terminology Where Appropriate#38ghengeveld merged 1 commit intoasync-library:masterfrom dhurlburtusa:patch-1
ghengeveld merged 1 commit intoasync-library:masterfrom
dhurlburtusa:patch-1
Conversation
Use "Fulfilled" in place of "resolved". Use "Pending" in place of "loading" when "loading" didn't feel more natural. Capitalize "O" in object when used as a datatype to use capitalization preferred by JSDoc and other tools. Only `boolean`, `number`, and `string` are expected to be all lowercase (assuming you are expecting the primitives and not the wrapper objects). Fix a few minor mistakes (grammar, unescaped tag syntax, etc).
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 5 5
Lines 525 525
Branches 112 112
=======================================
Hits 523 523
Misses 2 2Continue to review full report at Codecov.
|
ghengeveld
approved these changes
Mar 29, 2019
Member
ghengeveld
left a comment
ghengeveld
left a comment
There was a problem hiding this comment.
Excellent improvements, thanks for the sharp eye.
Member
|
@all-contributors please add @dhurlburtusa for doc |
Contributor
|
I've put up a pull request to add @dhurlburtusa! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to help the documentation to fall more inline with the v6.x Promise spec terminology.
Use "Fulfilled" in place of "resolved".
Use "Pending" in place of "loading" when "loading" didn't feel more natural.
Capitalize "O" in object when used as a datatype to use capitalization preferred by JSDoc and other tools. Only
boolean,number, andstringare expected to be all lowercase (assuming you are expecting the primitives and not the wrapper objects).Fix a few minor mistakes (grammar, unescaped tag syntax, etc).