Generate the phpdoc for the static create method of objects #1464
Conversation
stof
force-pushed
the
create_parameter_type
branch
from
d89703b to
2077f0d
Compare
stof
changed the title
| * SourceIdentity?: string, | ||
| * '@region'?: string|null, | ||
| * }|AssumeRoleRequest $input | ||
| */ | ||
| public static function create($input): self |
There was a problem hiding this comment.
This method is just a proxy for --construct.
I'm not sure duplicating this docbloc provides any value.
If the user enters invalid content, the STA should report the issue when calling new self($input); right?
There was a problem hiding this comment.
No. STA won't report anything because they will think that the method accept mixed. All SA tools are using functions as boundaries for the analysis. They don't rely on the implementation of methods to decide whether callers are using them properly.
Btw, this is one of the main blocker to increase the phpstan level (and probably also to lower the Psalm level or to re-enable the disabled Psalm rules). At level 6, phpstan complains about functions or properties that don't declare their type precisely because of this.
No description provided.