Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round 2 Audit findings #5

Merged
merged 14 commits into from
May 13, 2024
Merged

Round 2 Audit findings #5

merged 14 commits into from
May 13, 2024

Conversation

0xIryna
Copy link
Contributor

@0xIryna 0xIryna commented May 13, 2024

The following findings have been addressed

  • [H-1] fixed in the commit 73c0f0b
  • [H-2] fixed in the commit 687bdd5
  • [M-1] fixed in the commit 10fb48f
  • [M-2] fixed in the [commit] 6483713
  • [M-3] fixed in the commit 423ed33
  • [L-1] fixed in the commit d1b75ec
  • [L-2] implemented a maintenance window to prevent unlock requests between the last unlock call and the beginning of a new epoch. See commit d1b75ec
  • [I-2] implemented in the commit c2bcecf
  • [I-6] implemented in the commit cfc5f89
  • [I-9] implemented in the commit 24d810b
  • [G-1] implemented in the commit 390d52e
  • [G-3] implemented in the commit d9a2c77
  • [G-5] replaced memory with storage in the commit 76df9d9
  • [G-6] implemented in the commit fb2a0c7

Additionally, totalAssets logic has been fixed in the commit 5cf39a9

@0xIryna 0xIryna requested a review from romeroadrian May 13, 2024 08:08
@0xIryna 0xIryna merged commit c8f2713 into main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants