-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minimum required version metric. #85
feat: add minimum required version metric. #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solana-exporter only needs to query the SFDP API once a day or max every 6 or 12 hours (max).
c4bc531
to
6e4e8cf
Compare
22c866f
to
8fccfe2
Compare
8fccfe2
to
7157893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit tests :)
1868714
to
2fb14e6
Compare
2fb14e6
to
0c131a9
Compare
0c131a9
to
4b63c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it looks like I left a lot of issues, but they are generally all minor things. All round, I think this is a nice PR and I think you guys did a great job of introducing a whole new dimension to the exporter.
Please just address my (albeit generally minor) concerns and then once we are on the same page about those things I'll be happy to approve and merge.
1d5f046
to
910a973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for addressing the requests. I believe they were at all satisfied, but there are a few more concerns here. But overall, still nice stuff and thank you very much for the contribution so far already
910a973
to
6454cb6
Compare
6454cb6
to
2c6360e
Compare
21bd1ef
to
c26d17a
Compare
Summary
Add new metric
solana_min_required_version
to track the minimum requiredSolana version for foundation delegation program across different clusters.
Details
solana_min_required_version
with version and cluster labelsapi
package to handle non-RPC API callsTechnical Details
Testing