Skip to content

Initial code refactor on Pre-trained modules #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2019
Merged

Initial code refactor on Pre-trained modules #206

merged 5 commits into from
Sep 18, 2019

Conversation

gpengzhi
Copy link
Collaborator

Follow the code structure of texar-pytorch's pretrained module.

@gpengzhi
Copy link
Collaborator Author

@ZhitingHu Can you take a look at this PR?

ZhitingHu
ZhitingHu requested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@ZhitingHu ZhitingHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please make sure all docs are the same with Texar-pytorch whenever possible. If any interfaces/docs are different, pls list here to be reviewed and discussed.

@gpengzhi gpengzhi mentioned this pull request Sep 13, 2019
Merged
ZhitingHu
ZhitingHu reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@ZhitingHu ZhitingHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR support Pyhon2.7? If not, we will merge #208 first and make a release before merging this one.

@gpengzhi
Copy link
Collaborator Author

Does this PR support Pyhon2.7? If not, we will merge #208 first and make a release before merging this one.

It supports Python 2.7 which is also tested in CI.

@gpengzhi gpengzhi mentioned this pull request Sep 17, 2019
Merged
@gpengzhi gpengzhi merged commit bd2dbe4 into asyml:master Sep 18, 2019
@gpengzhi gpengzhi deleted the pretrained branch October 31, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhitingHu ZhitingHu ZhitingHu approved these changes

@AvinashBukkittu AvinashBukkittu Awaiting requested review from AvinashBukkittu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpengzhi @ZhitingHu @AvinashBukkittu