Skip to content

add notebook tags and tests #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Sep 9, 2022
Merged

add notebook tags and tests #889

merged 30 commits into from
Sep 9, 2022

Conversation

hepengfe
Copy link
Collaborator

This PR fixes #887

Description of changes

  • add tags to docs/notebook_tutorial/ocr.ipynb for notebook tests
  • add notebook tests for docs/notebook_tutorial/ocr.ipynb

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

tested all code cells that don't require users' prompts

@hepengfe hepengfe added the topic: data Issue about data loader modules and data processing related label Jul 25, 2022
@hepengfe hepengfe self-assigned this Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #889 (f39f591) into master (fe632e6) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   80.78%   81.00%   +0.22%     
==========================================
  Files         254      254              
  Lines       19388    19583     +195     
==========================================
+ Hits        15662    15864     +202     
+ Misses       3726     3719       -7     
Impacted Files Coverage Δ
forte/utils/utils.py 76.74% <0.00%> (-0.60%) ⬇️
tests/forte/remote_processor_test.py 100.00% <0.00%> (ø)
tests/forte/utils/tagging_scheme_test.py 100.00% <0.00%> (ø)
tests/forte/data/datapack_type_infer_test.py 100.00% <0.00%> (ø)
...rte/processors/ir/bert_based_query_creator_test.py 100.00% <0.00%> (ø)
...essors/data_augment/base_data_augment_processor.py 98.38% <0.00%> (+<0.01%) ⬆️
...rs/base/data_augment_replacement_processor_test.py 99.43% <0.00%> (+<0.01%) ⬆️
tests/forte/data/vocabulary_test.py 99.09% <0.00%> (+0.01%) ⬆️
forte/data/readers/ontonotes_reader.py 95.79% <0.00%> (+0.01%) ⬆️
tests/forte/advanced_pipeline_test.py 99.00% <0.00%> (+0.02%) ⬆️
... and 78 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hepengfe hepengfe marked this pull request as ready for review July 26, 2022 19:27
@hepengfe hepengfe requested a review from mylibrar July 26, 2022 19:27
@mylibrar mylibrar requested a review from hunterhector July 27, 2022 17:03
@hunterhector
Copy link
Member

I have added more comments on the doc directly, please take a look: https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html

@hunterhector
Copy link
Member

more comments added as annotations.

please also check the grammar with some tools.

@hepengfe
Copy link
Collaborator Author

more comments added as annotations.

please also check the grammar with some tools.

fixed it.

@mylibrar
Copy link
Collaborator

There are still some unresolved comments in https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html. Could you reply on that page of how you address these comments?

@hunterhector
Copy link
Member

I removed the resolved ones but there are still a few left, should simply need some quick-fixes

@hepengfe
Copy link
Collaborator Author

hepengfe commented Sep 2, 2022

I removed the resolved ones but there are still a few left, should simply need some quick-fixes

fixed them.

hunterhector
hunterhector previously approved these changes Sep 2, 2022
@hepengfe hepengfe merged commit 9bdad13 into asyml:master Sep 9, 2022
@hepengfe hepengfe deleted the ocr_tutorial_test branch September 9, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: data Issue about data loader modules and data processing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OCR example to notebook test cases
3 participants