-
Notifications
You must be signed in to change notification settings - Fork 60
add notebook tags and tests #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 80.78% 81.00% +0.22%
==========================================
Files 254 254
Lines 19388 19583 +195
==========================================
+ Hits 15662 15864 +202
+ Misses 3726 3719 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…into ocr_tutorial_test
I have added more comments on the doc directly, please take a look: https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html |
more comments added as annotations. please also check the grammar with some tools. |
fixed it. |
There are still some unresolved comments in https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html. Could you reply on that page of how you address these comments? |
I removed the resolved ones but there are still a few left, should simply need some quick-fixes |
fixed them. |
This PR fixes #887
Description of changes
docs/notebook_tutorial/ocr.ipynb
for notebook testsdocs/notebook_tutorial/ocr.ipynb
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
tested all code cells that don't require users' prompts