-
Notifications
You must be signed in to change notification settings - Fork 60
Storing Attribute Types in _type_attributes
#886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 80.85% 80.88% +0.02%
==========================================
Files 254 254
Lines 19460 19525 +65
==========================================
+ Hits 15734 15792 +58
- Misses 3726 3733 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mylibrar
reviewed
Aug 2, 2022
hunterhector
reviewed
Aug 8, 2022
In the future, for this type of more complex PR's , the better idea is to split out small steps and tackle them each one separately. |
81e3b63
to
ae61cc9
Compare
eff1dbc
to
8f2b6d1
Compare
mylibrar
reviewed
Aug 12, 2022
mylibrar
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #835.
Description of changes
This PR introduces a new structure of
_type_attributes
of Data Store. The_type_attributes
now store the type values of individual attributes of each entry in a Data Store. For example:Possible influences of this PR.
Through this PR,
getter
methods ofdataclass
attributes could be more comprehensive and return values based on their respective types. This is particularly useful in the case where attributes of typeEntry
are only stored through theirtid
. Through this PR, it can be easy to distinguish these attributes from the ones stored asint
.Test Conducted
The tests were conducted on
data_store_test
,data_pack_test
,data_store_serialization