Skip to content

Hook include forte only #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Hook include forte only #884

merged 3 commits into from
Jul 19, 2022

Conversation

hepengfe
Copy link
Collaborator

@hepengfe hepengfe commented Jul 18, 2022

This PR fixes #883

Description of changes

  • under .pre-commit-config.yaml, for all pre-commit hook check we only include files under forte folder.

Possible influences of this PR.

  • it prevents black formatting on unexpected files such as ft/onto/base_ontology.py which is automatically generated from ontology system.

Test Conducted

Describe what test cases are included for the PR.

@hepengfe hepengfe self-assigned this Jul 18, 2022
@hepengfe hepengfe requested a review from mylibrar July 18, 2022 23:59
@hepengfe hepengfe marked this pull request as ready for review July 18, 2022 23:59
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #884 (ef09731) into master (64eb43e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files         254      254           
  Lines       19401    19401           
=======================================
  Hits        15673    15673           
  Misses       3728     3728           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64eb43e...ef09731. Read the comment docs.

@hepengfe hepengfe changed the title Hook black include forte only Hook include forte only Jul 19, 2022
@hepengfe hepengfe merged commit 9e20ed5 into asyml:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit hook should check files under forte only
2 participants