Skip to content

Bug fix of the NameError where token_entries is not defined #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

Leolty
Copy link
Contributor

@Leolty Leolty commented Jun 4, 2022

This PR fixes #824.

Description of changes

Add one line to define the token_entries:

token_entries = input_pack.get(Token)

Possible influences of this PR.

Little change in README.md

Test Conducted

With this change, the python code in Quick Start Guide is runnable.

@hepengfe hepengfe added bug Something isn't working topic: examples Issue about examples labels Jun 4, 2022
@hepengfe
Copy link
Collaborator

hepengfe commented Jun 4, 2022

You could remove square brackets around the issue link.

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #825 (0e380cc) into master (9711823) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   80.50%   80.50%           
=======================================
  Files         252      252           
  Lines       19363    19363           
=======================================
  Hits        15588    15588           
  Misses       3775     3775           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9711823...0e380cc. Read the comment docs.

@Leolty
Copy link
Contributor Author

Leolty commented Jun 4, 2022

You could remove square brackets around the issue link.

square brackets have been removed

@hepengfe hepengfe self-requested a review June 4, 2022 16:44
@hepengfe hepengfe merged commit 6ef8ae0 into asyml:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: examples Issue about examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A NameError when running the python code in Quick Start Guide in README.md
2 participants