Add a new optional argument tid in DataStore.add_entries #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 81.02% 81.09% +0.06%
==========================================
Files 249 249
Lines 18716 18748 +32
==========================================
+ Hits 15164 15203 +39
+ Misses 3552 3545 -7
Continue to review full report at Codecov.
|
mylibrar
reviewed
May 9, 2022
hunterhector
reviewed
May 9, 2022
forte/data/data_store.py
Outdated
| entry: raw entry data in the list format. | ||
|
|
||
| Raises: | ||
| ValueError: raised when the entry type's sorting function is not |
There was a problem hiding this comment.
No ValueError is raised in this function, I only see KeyError
mylibrar
reviewed
May 23, 2022
…nk in _add_entry_raw()
mylibrar
reviewed
May 23, 2022
mylibrar
reviewed
May 23, 2022
| num_link = len( | ||
| self.data_store._DataStore__elements["forte.data.ontology.top.Link"] | ||
| ) | ||
| self.assertEqual(num_link, 2) |
There was a problem hiding this comment.
should probably test whether the tid is assigned correctly?
forte/data/data_store.py
Outdated
| @@ -384,12 +396,13 @@ def _new_group(self, type_name: str, member_type: str) -> List: | |||
| Args: | |||
| type_name: The fully qualified type name of the new entry. | |||
| member_type: Fully qualified name of its members. | |||
| tid: ``tid`` of the ``Group`` entry. | |||
There was a problem hiding this comment.
This, and other occurrences of tid, should expalin that tid can be optional and will be auto-assigned.
mylibrar
approved these changes
May 24, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #775 and #781
Description of changes
add_link_rawandadd_group_raw_add_entry_rawto help modularizingadd_annotation_raw,add_link_rawandadd_group_rawPossible influences of this PR.
Future functions that add new types of entries in raw format can use
_add_entry_rawTest Conducted
add_link_rawandadd_group_raw