Skip to content

Quick start guide #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 13, 2022
Merged

Quick start guide #730

merged 25 commits into from
Apr 13, 2022

Conversation

hepengfe
Copy link
Collaborator

@hepengfe hepengfe commented Apr 8, 2022

This PR fixes #729.

Description of changes

  • Merge overview.rst into README.md
  • change markdown hyperlinks to the web link directly
  • add file linking to README.md

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #730 (717bd27) into master (3c1425a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files         248      248           
  Lines       18509    18509           
=======================================
  Hits        15026    15026           
  Misses       3483     3483           
Impacted Files Coverage Δ
forte/data/data_pack.py 87.16% <ø> (ø)
forte/data/data_pack_dataset.py 95.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1425a...717bd27. Read the comment docs.

@hepengfe hepengfe self-assigned this Apr 8, 2022
@hepengfe hepengfe added the topic: docs Issue about docstrings and documentation label Apr 8, 2022
@hepengfe hepengfe marked this pull request as ready for review April 12, 2022 16:12
@hepengfe hepengfe marked this pull request as draft April 12, 2022 23:19
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay more attention when you are writing tutorials. Why are you even using this Word class from a test case? It makes no sense.

Co-authored-by: Hector <hunterhector@gmail.com>
@hepengfe hepengfe marked this pull request as ready for review April 13, 2022 20:52
@hunterhector hunterhector merged commit 8ec412f into asyml:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: docs Issue about docstrings and documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick start guide
2 participants