Skip to content

tested parameter signature overwriting docstrings #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 11, 2022
Merged

tested parameter signature overwriting docstrings #723

merged 12 commits into from
Apr 11, 2022

Conversation

hepengfe
Copy link
Collaborator

@hepengfe hepengfe commented Apr 5, 2022

This PR fixes #722.

Description of changes

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #723 (005cfc0) into master (f52e728) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   81.40%   81.43%   +0.02%     
==========================================
  Files         243      243              
  Lines       18398    18427      +29     
==========================================
+ Hits        14977    15006      +29     
  Misses       3421     3421              
Impacted Files Coverage Δ
forte/common/resources.py 82.92% <ø> (ø)
forte/data/base_extractor.py 75.00% <ø> (ø)
forte/data/base_pack.py 77.59% <ø> (ø)
forte/data/base_reader.py 87.40% <ø> (ø)
forte/data/base_store.py 70.45% <ø> (ø)
forte/data/batchers.py 91.75% <ø> (ø)
forte/data/converter/converter.py 95.78% <ø> (ø)
forte/data/converter/feature.py 87.00% <ø> (ø)
forte/data/data_pack.py 87.16% <ø> (ø)
forte/data/data_pack_dataset.py 98.55% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b0438...005cfc0. Read the comment docs.

@hepengfe hepengfe self-assigned this Apr 6, 2022
@hepengfe hepengfe added the topic: docs Issue about docstrings and documentation label Apr 6, 2022
@hepengfe hepengfe marked this pull request as ready for review April 8, 2022 00:11
@hepengfe hepengfe requested a review from hunterhector April 11, 2022 21:25
@hepengfe hepengfe merged commit 53567ae into asyml:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: docs Issue about docstrings and documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate type annotation generation of function parameters
2 participants