-
Notifications
You must be signed in to change notification settings - Fork 60
Add metric ontology #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric ontology #568
Conversation
Could you do the following to make sure the PR is up to standard?
|
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 234 234
Lines 16538 16538
=======================================
Hits 13243 13243
Misses 3295 3295
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normally also add the generated class to Forte repo so users don't have to re-generate these.
This PR fixes #566
Description of changes
Added
forte/ontology_specs/metric.json
Possible influences of this PR.
Due to the
ndarray
attribute inNdMetric
, the metric ontology spec isn't ready to be auto-generated by the current ontology generator yet.Test Conducted
Unit tests are to be added