Skip to content

Add metric ontology #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 19, 2022
Merged

Add metric ontology #568

merged 24 commits into from
Jan 19, 2022

Conversation

zhanyuanucb
Copy link
Collaborator

This PR fixes #566

Description of changes

Added forte/ontology_specs/metric.json

Possible influences of this PR.

Due to the ndarray attribute in NdMetric, the metric ontology spec isn't ready to be auto-generated by the current ontology generator yet.

Test Conducted

Unit tests are to be added

@hunterhector
Copy link
Member

Could you do the following to make sure the PR is up to standard?

  1. Change the PR name to the content instead of a number
  2. Make the branch up to date to the branch
  3. Make sure the CI passes.

@zhanyuanucb zhanyuanucb changed the title Issue#556 Add metric ontology Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #568 (0407b7a) into master (edd0f49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files         234      234           
  Lines       16538    16538           
=======================================
  Hits        13243    13243           
  Misses       3295     3295           
Impacted Files Coverage Δ
forte/data/ontology/core.py 84.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd0f49...0407b7a. Read the comment docs.

@hunterhector hunterhector marked this pull request as draft December 15, 2021 21:02
@zhanyuanucb zhanyuanucb marked this pull request as ready for review January 14, 2022 03:05
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally also add the generated class to Forte repo so users don't have to re-generate these.

@hunterhector hunterhector merged commit d34bdbc into asyml:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metric ontology
2 participants