Skip to content

Fixing a few configuration bugs #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

hunterhector
Copy link
Member

@hunterhector hunterhector commented Oct 5, 2021

This PR fixes #542

Description of changes

  1. Allow caster to assign a name to multipack automatically
  2. When creating new data pack in multi packs, allow assigning a name
  3. Add clear exception when constraint_type is not set in ontology code generator
  4. Do not query selector_config when it is None.
  5. Remove unused function new_data_pack in pack_processor
  6. Check for output_dir in writers.

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #541 (4648f2e) into master (9170f30) will decrease coverage by 0.00%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   79.59%   79.58%   -0.01%     
==========================================
  Files         222      222              
  Lines       15914    15917       +3     
==========================================
+ Hits        12667    12668       +1     
- Misses       3247     3249       +2     
Impacted Files Coverage Δ
forte/processors/base/pack_processor.py 86.66% <ø> (+3.33%) ⬆️
forte/processors/base/writers.py 68.60% <33.33%> (-1.28%) ⬇️
forte/data/ontology/ontology_code_generator.py 89.71% <50.00%> (-0.20%) ⬇️
forte/data/caster.py 95.23% <100.00%> (+0.23%) ⬆️
forte/data/multi_pack.py 78.11% <100.00%> (ø)
forte/pipeline.py 93.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9170f30...4648f2e. Read the comment docs.

@hunterhector hunterhector changed the title Temporary PR Fixing a few configuration bugs Oct 5, 2021
@hunterhector hunterhector merged commit ff8c61f into asyml:master Oct 5, 2021
@hunterhector hunterhector deleted the dev branch October 5, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various small bugs
1 participant