-
Notifications
You must be signed in to change notification settings - Fork 60
Add methods to allow binary serialization (built-in pickle) #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 79.22% 79.22% -0.01%
==========================================
Files 220 220
Lines 15530 15574 +44
==========================================
+ Hits 12304 12338 +34
- Misses 3226 3236 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #530.
Description of changes
On the high level:
A few details:
from_string
,to_string
methods for data pack to handle string-like data pack serialization.zip_pack
orserialize_method
.Possible influences of this PR.
Test Conducted
Added new tests trying out a matrix of configurations of
zipping
and the pickle methods to use.