-
Notifications
You must be signed in to change notification settings - Fork 60
Add the auto aligner to make subword tokenizer easier. #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 79.04% 79.20% +0.15%
==========================================
Files 215 216 +1
Lines 15277 15455 +178
==========================================
+ Hits 12076 12241 +165
- Misses 3201 3214 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #504.
Description of changes
If no word tokenization is provided:
forte.utils.utils.DiffAligner
is implemented, this will solve the issue even if the tokenizer does not contain span information.If word tokenization is provided, then will use the word tokenization directly to create sub-words.
Other changes:
lowercase
might change the length of the tokens for certain unicode character, this may cause issues in anotherLowerCaserProcessor
, so this is fixed together in this PR.Possible influences of this PR.
N/A
Test Conducted