Skip to content

Rename references to wrapper classes #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 9, 2021
Merged

Conversation

hunterhector
Copy link
Member

@hunterhector hunterhector commented Jun 8, 2021

This PR fixes #470.

This PR needs to be merged after asyml/forte-wrappers#44

Description of changes

Rename occurrences of forte-wrapper to forte

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #471 (fe7f7ed) into master (e83165b) will increase coverage by 0.00%.
The diff coverage is 99.02%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   80.73%   80.74%           
=======================================
  Files         204      204           
  Lines       14184    14103   -81     
=======================================
- Hits        11452    11388   -64     
+ Misses       2732     2715   -17     
Impacted Files Coverage Δ
forte/data/ontology/ontology_code_generator.py 90.26% <ø> (ø)
forte/processors/base/data_selector_for_da.py 45.76% <ø> (ø)
forte/processors/ir/search_processor.py 43.75% <ø> (ø)
ft/onto/base_ontology.py 94.38% <ø> (ø)
...e/processors/pretrained_encoder_processors_test.py 39.39% <80.00%> (+10.22%) ⬆️
forte/processors/misc/__init__.py 100.00% <100.00%> (ø)
forte/processors/misc/simple_processors.py 100.00% <100.00%> (ø)
tests/forte/data/data_pack_dataset_test.py 97.77% <100.00%> (+0.10%) ⬆️
...s/forte/data/extractor/attribute_extractor_test.py 97.95% <100.00%> (+0.08%) ⬆️
tests/forte/data/extractor/char_extractor_test.py 97.50% <100.00%> (+0.13%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83165b...fe7f7ed. Read the comment docs.

@hunterhector hunterhector merged commit 7e94fee into asyml:master Jun 9, 2021
@hunterhector hunterhector deleted the rename branch June 9, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forte wrapper class rename
1 participant