Support prediction for NER new task. #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiaqiang-Ruan
changed the title
hunterhector
reviewed
Dec 9, 2020
examples/ner_new/main_predict.py
Outdated
| print('---- example -----') | ||
| print("sentence: ", sent) | ||
| print("ner_tags: ", ner_tags) | ||
| print(evaluator.get_result()) |
There was a problem hiding this comment.
Can we get the whole dataset result at the end?
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 81.13% 81.13%
=======================================
Files 209 209
Lines 14615 14615
=======================================
Hits 11858 11858
Misses 2757 2757 Continue to review full report at Codecov.
|
examples/ner_new/main_predict.py
Outdated
|
|
||
| def predict_forward_fn(model, batch): | ||
| '''Use model and batch data to predict ner tag.''' | ||
| word = batch["text_tag"]["tensor"] |
There was a problem hiding this comment.
It would be better if you can add typing hint for all variables here.
…to folder tagging;
| predictor = Predictor(batch_size=config_predict['batch_size'], | ||
| model=saved_model, | ||
| predict_forward_fn=predict_forward_fn, | ||
| feature_resource=train_state['feature_resource']) |
There was a problem hiding this comment.
Actually I think the better way to put predict_forward_fn is make it an abstract function of Predictor?
hunterhector
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changesAdd the user file for running the prediction for NER task on Conll03 task.
Possible influences of this PR.
The code will use the extractor framework and will need the output from train process to do the prediction.
Test Conducted
Small dataset validation is done.