Biological NER predictor pack() missing context parameter #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterhector
reviewed
Feb 8, 2022
| from forte.processors.base.batch_processor import RequestPackingProcessor | ||
| from ft.onto.base_ontology import EntityMention, Subword | ||
| from ft.onto.base_ontology import EntityMention, Subword, Token, Sentence |
There was a problem hiding this comment.
Should be careful about import orders, this is part of python convention
There was a problem hiding this comment.
Do you mean the order of modules after from ft.onto.base_ontology import should follow alphabetic order?
There was a problem hiding this comment.
…forte-wrappers into bio_ner_predictor_fix
hunterhector
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes asyml/forte#622.
Description of changes
Add
contextparameter to the function to adapt API interface changes even thoughcontextis not needed.Possible influences of this PR.
Indexer can run successfully in the clinical pipeline example
https://github.com/asyml/forte/tree/master/examples/clinical_pipeline
Test Conducted
self.num_packs.