Fix subtle bug in cleanup code in PyErr_NormalizeException(), detected

by Marc Lemburg. There's a path through the code where *val is NULL, but value isn't, and value should be DECREF'ed.
asvetlov · Dec 9, 1997 · 19b55f2 · 19b55f2
1 parent a2e268a
commit 19b55f2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Python/errors.c b/Python/errors.c
@@ -219,8 +219,8 @@ PyErr_NormalizeException(exc, val, tb)
 	*val = value;
 	return;
 finally:
-	Py_DECREF(*exc);
-	Py_DECREF(*val);
+	Py_DECREF(type);
+	Py_DECREF(value);
 	Py_XDECREF(*tb);
 	PyErr_Fetch(exc, val, tb);
 	/* normalize recursively */