Skip to content

Fix for ResourcePackage #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for ResourcePackage #22

wants to merge 5 commits into from

Conversation

kpentchev
Copy link

implemented fix for ResourcePackage wrt key generation. When - was present in name, an endless loop might have occurred during inflating. Added a test case.

@HansWouters
Copy link

Hi,

I have a stacktrace (below) from JConsole from 2 threads that use a lot of CPU, is it possible that your fix fixes this? Unfortunately I don't see the filename.

Name: ajp-apr-18042-exec-10
State: RUNNABLE
Total blocked: 42  Total waited: 140

Stack trace: 
java.util.zip.Inflater.inflateBytes(Native Method)
java.util.zip.Inflater.inflate(Inflater.java:256)
   - locked java.util.zip.ZStreamRef@25ce3896
java.util.zip.Inflater.inflate(Inflater.java:274)
com.asual.lesscss.ResourcePackage.inflate(ResourcePackage.java:192)
com.asual.lesscss.ResourcePackage.fromString(ResourcePackage.java:83)
com.asual.lesscss.ResourceServlet.service(ResourceServlet.java:163)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants