Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding error with automodapi_writereprocessed and py2 #1

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Nov 10, 2016

Same as astropy/astropy-helpers#244
Should I close the PR on astropy-helpers ? What's the next step for sphinx-automodapi, do you plan to do a release and use it directly in astropy-helpers and astropy ?

@astrofrog
Copy link
Member

Thanks! I think we have to make a final decision about whether to go ahead with this standalone package, but assuming we do then we should indeed move the issues here. We should be able to release this standalone package pretty quickly.

@coveralls
Copy link

coveralls commented Nov 10, 2016

Coverage Status

Coverage increased (+1.4%) to 45.929% when pulling de3002d on saimn:automodapi-fix-encoding into 1c9c17f on astropy:master.

@justincely
Copy link

@astrofrog I've started pulling this into a few STScI repos, so far with success - and would love an initial release on pypi or conda so we can pull it into RTD. Any plans for a release or any help I can provide?

@astrofrog astrofrog merged commit ea0444b into astropy:master Dec 8, 2016
@astrofrog
Copy link
Member

@saimn @justincely - we're going to go ahead and try releasing this as a standalone package, but let's not move issues over from astropy-helpers yet, since this is an experiment for now. If you find issues with it, you can open issues here, but no point moving issues over from astropy-helpers until we are sure we are removing the code there.

@saimn saimn deleted the automodapi-fix-encoding branch December 9, 2016 08:20
@saimn
Copy link
Contributor Author

saimn commented Dec 9, 2016

@astrofrog - Ok, great !

@justincely
Copy link

@astrofrog sounds great!

@astrofrog
Copy link
Member

@justincely - I've made an initial release on PyPI - let me know if you run into any issues!

astrofrog added a commit that referenced this pull request Jan 27, 2018
Fix encoding error with automodapi_writereprocessed and py2
astrofrog added a commit that referenced this pull request Jan 27, 2018
Fix encoding error with automodapi_writereprocessed and py2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants