1D Wavelength Calibration and 2D tilt correction #265
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 87.64% 90.19% +2.54%
==========================================
Files 15 17 +2
Lines 1279 1846 +567
==========================================
+ Hits 1121 1665 +544
- Misses 158 181 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok, looks like all the builds are failing because of a matplotlib dependency that I added. I'll need to make matplotlib and the plotting functionality optional. |
|
Docs build works with Jupyter Notebook examples. Take a look at https://specreduce--265.org.readthedocs.build/en/265/wavelength_calibration/wavelength_calibration.html |
hpparvi
changed the title
hpparvi
changed the title
| "from matplotlib.pyplot import setp, subplots, close, rc\n", | ||
| "from specutils import Spectrum1D\n", | ||
| "\n", | ||
| "from specreduce.lswavecal1d import WavelengthSolution1D\n", |
There was a problem hiding this comment.
should be from specreduce import WavelengthCalibration1D if you want to import it in init like wavelengh_calibration, otherwise just a typo and should be specreduce.lswavecal1d import WavelengthSolution1D
There was a problem hiding this comment.
Thanks for catching this @cshanahan1. This notebook was outdated, and I shouldn't have included it in the PR in the first place.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "flux = getdata('shane_kast_blue_600_4310_d55.fits', 1).astype('d')\n", |
There was a problem hiding this comment.
need to provide the path ../docs/wavelength_calibration/wavelength_calibration/, and also it looks like the file in that directory is different shane_kast_blue_600_4310_d55.fits so either change the filename to that one or add the correct file.
| ], | ||
| "source": [ | ||
| "%%time\n", | ||
| "ws = WavelengthSolution1D(arc_spectra=arc_spectrum, line_lists=[['CdI', 'HgI', 'HeI']], wlbounds=(3200, 5700))\n", |
There was a problem hiding this comment.
This class doesn't exist, if this should replaced with WavelengthCalibration1D and wlbounds needs to be line_list_bounds and ref_pixel should be supplied. Also remove %%time from the top of this cell. I got a traceback when I tried this replacement with 'ref_pix', so i'll wait to continue reviewing the rest of this notebook
… a sum of nearest-line distances between a theoretical line list and a transformed observed line list.
…with respect to x.
Renamed `wavecal.py` to `lswavecal1d.py` and refactored the `WavelengthSolution1D` class for improved clarity and functionality. Added new methods like `refine_fit`, `pix_to_wav`, and `wav_to_pix`, and modified existing ones to enhance flexibility and maintainability.
Introduce `WavelengthSolution2D` class for 2D wavelength calibration, extending functionality from 1D calibration.
…el and spectral frames.
… type hints, documentation, and method structure. Added new methods for calculating inverse transformations and derivatives. Enhanced plotting functionality with additional parameters and refined docstrings for clarity.
…where `arc_spectra` is `None`.
… `plim` parameter for pixel range control in plotting.
…, and modularity, while resolving associated issues. Enhanced methods for handling pixel-to-wavelength mappings, line-matching processes, and plotting capabilities. Added new functions and properties for better control over data and fit refinement.
…ns with setters to ensure proper masking and validation. Added `plot_lines_pix` and `plot_lines_wav` methods for enhanced modularity in plotting observed and theoretical lines.
…on't break backwards compatibility (quite yet).
… without matplotlib installed.
…, and functionality. Added detailed docstrings, refined methods for arc line identification, transformation fitting, and matching lines. Improved internal handling of parameters and optimized logic.
…onsistency and improved usability. Updated variable names and docstrings for better clarity and alignment with the code's functionality. Simplified return behavior in `match_lines` to support optional concatenation.
…xibility in 2D spectrum rectification. Updated methods to use these parameters, ensuring proper alignment and control over mask handling. Also improved documentation and refactored variable naming.
…uns, but must be improved to ensure that the results are correct.
…ompatibility updates.
…ling of unit-aware array values.
This PR introduces a new 1D wavelength calibration class,
specreduce.wavecal1d.WavelengthCalibration1D, intended to fully replace the existingspecreduce.wavelength_calibration.WavelengthCalibration1Din version 2.0 (I'm keeping the previous class for backwards compatibility), and a new tilt correction class for 2D tilt correction. It also includes documentation demonstrating how to use the class for both interactive and automated wavelength calibration workflows.The core functionality is ready for review. I still need to tidy up some of the docstrings and ensure the ReadTheDocs configuration correctly supports Jupyter notebooks, but otherwise everything is in place. Feel free to test it out and let me know if you run into any issues.
The only (somewhat) significant feature currently missing is support for generating standard spectroscopic
-GRIand-GRAWCSs as described in Greisen et al. (2006). At the moment, the class supports only GWCS-based WCS. This is something we can address in a future update.