Skip to content

Improper use of mask in HorneExtract #167

@cshanahan1

Description

@cshanahan1

A user may (optionally) provide a mask along with their data to HorneExtract. Any NaNs in the image are added also to this mask (or used to create one, if one wasn't provided). If the dispersion axis is X, and there are ANY masked pixels in that column even outside of the trace, that column will not be fit.

I've attached some images below to demonstrate the issue. I created a flat spectrum with a gaussian profile, masked a single pixel in a subset of columns, and the extracted spectrum shows no values in those columns with masked pixels were fit. The mask wasn't being used to omit pixels from the fit, it is used to discard entire rows/columns.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions