Skip to content

DOC: making sure doctests pass more often #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 10, 2025

L385 kept failing in CI

@bsipocz bsipocz added this to the v1.7.1 milestone Aug 10, 2025
Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I kind of like it if we show the phase progression. I'd say that particular service isn't well suited for this test because it occasionally is loaded, and then jobs may be QUEUED for a long, long time.

On the other hand, there is http://voparis-rr.obspm.fr/tap, which is also likely to stay around (it's part of the reg.g-vo.org mirror system) and that should basically never have long-running jobs. Perhaps the code tested should be modified to do something like this:

tap_service = vo.dal.TAPService("http://voparis-rr.obspm.fr/tap")
ex_query = """
SELECT TOP 10 ivoid, res_title
FROM rr.resource
"""
async_job = tap_service.submit_job(ex_query)
async_job.run().wait()

For robustness, I think we should be explicitly waiting for COMPLETED (but with a short timeout), though.

I'd be happy to add HTTPS support to voparis-rr if that makes the decision simpler.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 17, 2025

OK, I've gone now the other way, added a full, non ellipsed example and ignore the specifics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants