-
-
Notifications
You must be signed in to change notification settings - Fork 419
ESA HST module PyVO migration #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ESA HST module PyVO migration #3367
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3367 +/- ##
==========================================
+ Coverage 70.08% 70.27% +0.19%
==========================================
Files 232 232
Lines 19890 19907 +17
==========================================
+ Hits 13940 13990 +50
+ Misses 5950 5917 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @JorgeHigueraFombuena , great to see your first PR to Astroquery! @bsipocz , he is a new team member at ESA and I have been supporting him on this branch. It seems all the checks are passing now, great! Please let us know if you have comments or concerns. Thanks! |
Welcome @JorgeHigueraFombuena! And straight into the deep end. I have some deadlines to meet before the long weekend and will be at a conference next week. But I'll try to get this reviewed quickly (passing the tests is already a great sign, but I expect to have some comments on making the API more consistent with the other modules). |
Hi @bsipocz I hope the code is clear enough to make reviewing easy! |
Dear astroquery team, this ticket aims to update the HST to make use of the PyVO module.
Happy to contribute!!
CC @esdc-esac-esa-int