Skip to content

ESA HST module PyVO migration #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JorgeHigueraFombuena
Copy link

Dear astroquery team, this ticket aims to update the HST to make use of the PyVO module.

Happy to contribute!!

CC @esdc-esac-esa-int

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (1becbba) to head (769be07).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/esa/hubble/core.py 85.71% 7 Missing ⚠️
astroquery/esa/utils/utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3367      +/-   ##
==========================================
+ Coverage   70.08%   70.27%   +0.19%     
==========================================
  Files         232      232              
  Lines       19890    19907      +17     
==========================================
+ Hits        13940    13990      +50     
+ Misses       5950     5917      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jespinosaar
Copy link
Contributor

Hi @JorgeHigueraFombuena , great to see your first PR to Astroquery! @bsipocz , he is a new team member at ESA and I have been supporting him on this branch.

It seems all the checks are passing now, great! Please let us know if you have comments or concerns. Thanks!

@bsipocz
Copy link
Member

bsipocz commented Jul 3, 2025

Welcome @JorgeHigueraFombuena! And straight into the deep end.

I have some deadlines to meet before the long weekend and will be at a conference next week. But I'll try to get this reviewed quickly (passing the tests is already a great sign, but I expect to have some comments on making the API more consistent with the other modules).

@JorgeHigueraFombuena
Copy link
Author

Hi @bsipocz

I hope the code is clear enough to make reviewing easy!
Thanks!

@bsipocz bsipocz self-requested a review July 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants