Skip to content

Access to NOIRLab Astro Data Archive #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

weaverba137
Copy link
Member

This PR supersedes #1701.

The initial commit simply restores the NOIRLab files to the state and content they were when #1701 was last worked on. Further work and testing will be needed to meet astroquery standards.

@weaverba137
Copy link
Member Author

weaverba137 commented Jun 26, 2025

TO DO items identified (i.e. before even starting the review process):

  • Proofread noirlab/noirlab.rst and verify examples.
  • Remove telescope holdings from init file. These are certainly outdated. Link to the about page.
  • Check required acknowledgment(s).
  • Get remote tests working.
  • Add non-remote tests to increase coverage, e.g. monkeypatch.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 85.14851% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (82cab62) to head (f63e091).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/noirlab/core.py 84.04% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
+ Coverage   70.07%   70.15%   +0.07%     
==========================================
  Files         232      234       +2     
  Lines       19893    19994     +101     
==========================================
+ Hits        13940    14026      +86     
- Misses       5953     5968      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weaverba137
Copy link
Member Author

Note to self: tox -e py310-test-online -- -P noirlab to do remote tests on only astroquery.noirlab.

@bsipocz
Copy link
Member

bsipocz commented Jun 27, 2025

You also need -R to run the remote tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants