MAINT: work around setuptools internals for 80.3 #3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3311 +/- ##
=======================================
Coverage 69.87% 69.87%
=======================================
Files 232 232
Lines 19742 19742
=======================================
Hits 13795 13795
Misses 5947 5947 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality in setuptools got removed without deprecation (pypa/setuptools#4963), and that threw a wrench in our infrastructure, too.
However, there won't be any more helpers released on pypi, so this PR removes the usage of said setuptools functionality as a quick fix while an actual packaging modernization for astroquery is in the works.
(This will only need a changelog if we release before the full refactoring, thus I leave as is; and if needed, I'll add a changelog right before release time.)
The other workaround could be to limit setuptools version, but I'm hopeful that the change will actually be reverted soon and they will do another release.
closes #3309