-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vo module #1679
Added vo module #1679
Conversation
Before doing any review here, I suppose we need to discuss the ideas here a bit, both from the user perspective as well as the holistic view of what goes into astroquery vs pyvo. |
|
@andamian when you have a chance, could you revisit this? Are the needed pyvo changes done? |
This was completely out of my radar. I'll add it to my list of things to do. I don't think there's anything missing in |
A long time ago, there was also a |
I'm going through the open PRs, and while the motivation here is something more generic I suppose this could certainly address my desire of one/multiple VO based baseclass: #2360 |
Overall, regarding the generic module I think it's an interesting idea and certainly needs more discussion between pyvo and astroquery maintainers. |
If there are no objections, I think I'll close this here and try it in |
OK. Closing it here. |
Thanks @andamian! |
This is a generic VO module for image searches that uses only VO services and standards to implement astroquery basic API. Data providers, such as ALMA or CADC, can further customize this functionality for their own modules.
Note that this PR depends on a number of changes in
pyvo
that have not been released yet but will be in the near future.