Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vo module #1679

Closed
wants to merge 1 commit into from
Closed

Added vo module #1679

wants to merge 1 commit into from

Conversation

andamian
Copy link

This is a generic VO module for image searches that uses only VO services and standards to implement astroquery basic API. Data providers, such as ALMA or CADC, can further customize this functionality for their own modules.

Note that this PR depends on a number of changes in pyvo that have not been released yet but will be in the near future.

@astropy-bot astropy-bot bot added the vo label Mar 10, 2020
@bsipocz
Copy link
Member

bsipocz commented Mar 10, 2020

Before doing any review here, I suppose we need to discuss the ideas here a bit, both from the user perspective as well as the holistic view of what goes into astroquery vs pyvo.

@andamian
Copy link
Author

pyvo contains the IVOA spec implementations (One big exception is VOTable which is already part of the core astropy). It is a library for developers that are familiar with IVOA standards.

astroquery on the other hand offers a common API for accessing data from various data providers. The users of astroquery do not need to know the details of the underlying access mechanisms and protocols. To that end, the vo module proposed in this PR attempts to do just that: implement that generic astroquery API by putting together protocols implemented in pyvo for those data providers that offer VO services. Users need to know little (if anything) about these protocols while the data providers can get instant exposure to the astroquery general community.

@keflavich
Copy link
Contributor

@andamian when you have a chance, could you revisit this? Are the needed pyvo changes done?

@andamian
Copy link
Author

andamian commented Feb 18, 2021

This was completely out of my radar. I'll add it to my list of things to do. I don't think there's anything missing in pyvo.

@pllim
Copy link
Member

pllim commented May 25, 2021

A long time ago, there was also a astropy.vo module, so having astroquery.vo is going to be super confusing.

@bsipocz
Copy link
Member

bsipocz commented May 16, 2022

I'm going through the open PRs, and while the motivation here is something more generic I suppose this could certainly address my desire of one/multiple VO based baseclass: #2360

@bsipocz
Copy link
Member

bsipocz commented May 16, 2022

Overall, regarding the generic module I think it's an interesting idea and certainly needs more discussion between pyvo and astroquery maintainers.

@andamian
Copy link
Author

If there are no objections, I think I'll close this here and try it in PyVO instead to get more exposure from the IVOA folks.

@andamian
Copy link
Author

OK. Closing it here.

@andamian andamian closed this May 17, 2022
@bsipocz
Copy link
Member

bsipocz commented May 17, 2022

Thanks @andamian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants