Correct BitArray benchmark to use actual multi-bit flag arrays #144
+26
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the votable test to use proper 2D arrays for BitArray benchmark.
It replaces scalar boolean columns with actual multi-dimensional flag arrays to accurately benchmark BitArray parsing performance. The previous implementation was forcing scalar bools into BitArrays
This could be related to the issues where the benchmarks on astropy PRs are timing out.
However I'm not sure why that would be the case, as if run locally (the version before these changes) it completes within a few seconds for each test, whereas the timeouts in the workflow runs happen after 60 seconds.
In any case I've run this version locally and see these run times:
If we think that it is a timeout due to the row size I could reduce it down by some fraction, but perhaps better not to include it in this PR?