Skip to content

Conversation

@astrofrog
Copy link
Member

We should make sure that there are no syntax or code issues and that the benchmarks run with the latest version of astropy, otherwise we risk introducing broken benchmarks here and breaking the astropy CI subsequently.

@astrofrog
Copy link
Member Author

I've expanded the test suite to do what we used to do on Travis which is to test against a bunch of stable releases of astropy as well as the developer version, since we need to make sure the benchmark suite can work with a range of versions in order to produce useful graphs.

@astrofrog astrofrog requested a review from pllim May 15, 2024 11:36
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can even consider replacing 61 with just stable so we don't have to come back and update this every release.

astrofrog and others added 3 commits May 15, 2024 13:55
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@astrofrog astrofrog requested a review from pllim May 15, 2024 12:58
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants