Remove condition import for SQLAlcRow #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
requested review from
dimberman,
tatiana,
utkarsharma2 and
sunank200
as code owners
for more information, see https://pre-commit.ci
|
Looks like the CI is failing. Just rerun it. Let's see how it works |
pankajkoti
approved these changes
May 6, 2024
There was a problem hiding this comment.
LGTM. Some tests seems to be failing. Should we fix them in this PR or a subsequent PR is better? Leaving the call to you to decide @pankajastro
It still fails. I think we might need to check it 🤔 |
Yes, it is broken since 2.9 I'm fixing in #2149 |
yeah, the failure is unrelated to this change, I'll merge this one to fix the import error in example DAG and will fix CI in #2149 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since airflow is pin to >2.7.0 remove conditional import
https://github.com/astronomer/astro-sdk/blob/main/python-sdk/pyproject.toml#L20