Skip to content

Create trigger_utils_tests #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create trigger_utils_tests #163

wants to merge 1 commit into from

Conversation

arjunsavel
Copy link
Collaborator

No description provided.

@kelle
Copy link
Contributor

kelle commented May 28, 2025

Sorry, i'm not following...what does this do?

@arjunsavel
Copy link
Collaborator Author

Any time there are changes to the template, this triggers a run of astrodb utils!

with:
token: ${{ secrets.UTILS_TOKEN }}
repository: astrodbtoolkit/astrodb_utils
event-type: run-tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "run-tests" refer to? How does this action know what to run? I would have thought it would need the action name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs-on: ubuntu-latest
steps:
- name: Trigger AstroDB Utils Tests workflow
uses: peter-evans/repository-dispatch@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why peter-evans? Is there no official github action we can use?

- name: Trigger AstroDB Utils Tests workflow
uses: peter-evans/repository-dispatch@v2
with:
token: ${{ secrets.UTILS_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a token in this repo (template)....maybe the token needs to be in astrodb_utils?

@kelle
Copy link
Contributor

kelle commented May 28, 2025

Problem with this current logic is that running the astrodb_utils tests will still run on whatever outdated commit it's pointing to in the template. Before running the tests, we need to update astrodb-template to the latest commit. OR , better yet, we should we write the astrodb_utils tests to just clone the template repo every time rather than using a submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants