-
Notifications
You must be signed in to change notification settings - Fork 3
Create trigger_utils_tests #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Sorry, i'm not following...what does this do? |
Any time there are changes to the template, this triggers a run of astrodb utils! |
with: | ||
token: ${{ secrets.UTILS_TOKEN }} | ||
repository: astrodbtoolkit/astrodb_utils | ||
event-type: run-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "run-tests" refer to? How does this action know what to run? I would have thought it would need the action name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is called run_tests! https://github.com/astrodbtoolkit/astrodb_utils/blob/main/.github/workflows/run_tests.yml
runs-on: ubuntu-latest | ||
steps: | ||
- name: Trigger AstroDB Utils Tests workflow | ||
uses: peter-evans/repository-dispatch@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why peter-evans? Is there no official github action we can use?
- name: Trigger AstroDB Utils Tests workflow | ||
uses: peter-evans/repository-dispatch@v2 | ||
with: | ||
token: ${{ secrets.UTILS_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a token in this repo (template)....maybe the token needs to be in astrodb_utils?
Problem with this current logic is that running the |
No description provided.