Update PhotometryFilters.json #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofit PhotometryFilters.json from SIMPLEdb with schema from astrodb-template (ie `width` vs `withd_angstroms`)
|
Ah, I see, in SIMPLE, we didn't follow the SVO Filter Profile Service naming convention. Which we do want to use in the template. I've opened #158 and hopefully one of the interns will work on this. I also think I want to make a test which makes sure the filters can be found by SVO. lemme try and write that in this PR. |
|
And congrats on your first pull request!!!! This looks perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrofit PhotometryFilters.json from SIMPLEdb with schema from astrodb-template (ie
widthvswithd_angstroms)