Repository navigation
perf(julia_helpers): convert lists with PythonCall.pyconvert - #1425
Open
MilesCranmerBot wants to merge 1 commit into
Open
MilesCranmerBot wants to merge 1 commit into
MilesCranmerBot wants to merge 1 commit into
Conversation
…nvert juliacall.convert evaluates a new closure on first use, which Julia compiles at runtime; PythonCall.pyconvert can be precompiled. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jl_arrayconverted lists withjuliacall.convert, which builds a new Julia closure in every Python session, so every fresh process compiled it during the first fit (0.2 s).PythonCall.pyconvertis an ordinary function, which astroautomata/SymbolicRegression.jl#768 precompiles. The resulting arrays are the same.With #768, on a 12-core node with Julia 1.13 (median of 5 fresh processes, measured to the end of the first fit):
PySRRegressor(niterations=1)Fixed-seed halls of fame are byte-identical.
test_main.pyandtest_startup.py: 205 passed, 1 skipped.