Repository navigation
chore: remove unused PYTHON_JULIACALL_OPTLEVEL setting - #1424
Open
MilesCranmerBot wants to merge 2 commits into
Open
MilesCranmerBot wants to merge 2 commits into
MilesCranmerBot wants to merge 2 commits into
Conversation
PySR set PYTHON_JULIACALL_OPTLEVEL=3, but juliacall reads the optimization level from PYTHON_JULIACALL_OPTIMIZE, so Julia ran at the default -O2. Set PYTHON_JULIACALL_OPTIMIZE instead. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
juliacall has no optlevel option, so this setting never took effect and Julia has always run at -O2. Enabling -O3 through PYTHON_JULIACALL_OPTIMIZE gave no speedup on a 128-core node and forced a one-time recompile of about 3 minutes, so keep -O2 and drop the dead line. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
MilesCranmerBot
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySR sets
PYTHON_JULIACALL_OPTLEVEL=3on import, meaning to run Julia at-O3. juliacall has nooptleveloption (it hasoptimizeandmin_optlevel, in every release since at least 0.9.10), so the setting never took effect and Julia has always run at the default-O2.Setting
PYTHON_JULIACALL_OPTIMIZE=3would enable-O3, but it does not help. On one 128-core Rusty node with PySR 2.7.0 (K=300, 3 interleaved repetitions), search speed was:Both differences are within run-to-run spread. Switching would also force every user through a one-time recompile of about 3 minutes, since Julia caches compiled packages per optimization level.
This removes the dead line and its mention in the warning shown when juliacall was imported before PySR. Behavior is unchanged.