Refactor development dependency configuration #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 18, 2024
Comment on lines
+115
to
+119
| /// Return a new [`DevGroupsSpecification`] with development dependencies included by default. | ||
| /// | ||
| /// This is appropriate in projects, where the `dev` group is synced by default. | ||
| #[must_use] | ||
| pub fn with_default_dev(self) -> Self { |
There was a problem hiding this comment.
This will become with_default_groups or something in the future.
zanieb
force-pushed
the
zb/dev-refactor
branch
2 times, most recently
from
488eaa7
to
9048b37
Compare
This was referenced Oct 18, 2024
zanieb
force-pushed
the
zb/dev-refactor
branch
from
9048b37
to
b879696
Compare
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8090
Unblocks #8274
Refactors
DevModeandDevSpecificationinto a shared typeDevGroupsSpecificationthat allows us to track if--devwas implicitly or explicitly provided.