Add --group and --only-group to uv sync and includes all groups in uv lock
#8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 10, 2024
Comment on lines
+276
to
+281
| let dev: Vec<_> = workspace | ||
| .pyproject_toml() | ||
| .dependency_groups | ||
| .iter() | ||
| .flat_map(|groups| groups.keys().cloned()) | ||
| .chain(std::iter::once(DEV_DEPENDENCIES.clone())) | ||
| .collect(); |
There was a problem hiding this comment.
This took me a while to track down — this is critical to actually respect groups.
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
8512acf
to
9286d32
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
9286d32
to
df853e8
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
df853e8
to
57d7e66
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
57d7e66
to
8f76381
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
8f76381
to
b96abd8
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
b96abd8
to
5264aa2
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
5264aa2
to
882431f
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
882431f
to
e960e73
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
e960e73
to
97f81d7
Compare
charliermarsh
approved these changes
Oct 16, 2024
|
I guess we also need this on |
zanieb
added a commit
that referenced
this pull request
Oct 16, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
|
I'm interested in it for uv pip compile
…On Wed, Oct 16, 2024, 5:38 PM Charlie Marsh ***@***.***> wrote:
I guess we also need this on uv run, and maybe also in uv pip?
—
Reply to this email directly, view it on GitHub
<#8110 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBD5ABDMXDAPRTU7KBTZ33MEZAVCNFSM6AAAAABPXUA2NOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGAYTCMRVGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
zanieb
force-pushed
the
zb/735-sync-lock
branch
2 times, most recently
from
946fbc0
to
f192195
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
f192195
to
e4037bb
Compare
charliermarsh
added a commit
that referenced
this pull request
Oct 17, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
… in `uv lock` (#8110) Part of #8090 Adds the ability to include a group (`--group`) in the sync or _only_ sync a group (`--only-group`). Includes all groups in the resolution, which will have the same limitations as extras as described in #6981. There's a great deal of refactoring of the "development" concept into "groups" behind the scenes that I am continuing to defer here to minimize the diff. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved. The current proposal is that we'll just "combine' the `dev-dependencies` contents into the `dev` group.
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
… in `uv lock` (#8110) Part of #8090 Adds the ability to include a group (`--group`) in the sync or _only_ sync a group (`--only-group`). Includes all groups in the resolution, which will have the same limitations as extras as described in #6981. There's a great deal of refactoring of the "development" concept into "groups" behind the scenes that I am continuing to defer here to minimize the diff. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved. The current proposal is that we'll just "combine' the `dev-dependencies` contents into the `dev` group.
charliermarsh
added a commit
that referenced
this pull request
Oct 20, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
… in `uv lock` (#8110) Part of #8090 Adds the ability to include a group (`--group`) in the sync or _only_ sync a group (`--only-group`). Includes all groups in the resolution, which will have the same limitations as extras as described in #6981. There's a great deal of refactoring of the "development" concept into "groups" behind the scenes that I am continuing to defer here to minimize the diff. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved. The current proposal is that we'll just "combine' the `dev-dependencies` contents into the `dev` group.
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
… in `uv lock` (#8110) Part of #8090 Adds the ability to include a group (`--group`) in the sync or _only_ sync a group (`--only-group`). Includes all groups in the resolution, which will have the same limitations as extras as described in #6981. There's a great deal of refactoring of the "development" concept into "groups" behind the scenes that I am continuing to defer here to minimize the diff. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved. The current proposal is that we'll just "combine' the `dev-dependencies` contents into the `dev` group.
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8090
Adds the ability to include a group (
--group) in the sync or only sync a group (--only-group). Includes all groups in the resolution, which will have the same limitations as extras as described in #6981.There's a great deal of refactoring of the "development" concept into "groups" behind the scenes that I am continuing to defer here to minimize the diff.
Additionally, this does not yet resolve interactions with the existing
devgroup — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved. The current proposal is that we'll just "combine' thedev-dependenciescontents into thedevgroup.