Add support for reading PEP 735 dependency groups #8104
Merged
+75
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
compatibility
zanieb
force-pushed
the
zb/735-read
branch
2 times, most recently
from
26e0950
to
3d82281
Compare
charliermarsh
approved these changes
Oct 11, 2024
konstin
reviewed
Oct 15, 2024
| @@ -43,6 +43,8 @@ pub struct PyProjectToml { | |||
| pub project: Option<Project>, | |||
| /// Tool-specific metadata. | |||
| pub tool: Option<Tool>, | |||
| /// Non-project dependency groups, as defined in PEP 735. | |||
| pub dependency_groups: Option<BTreeMap<ExtraName, Vec<String>>>, | |||
There was a problem hiding this comment.
I'd put it in a newtype so we can implement a get_group_resolved on top of it. PyO3/pyproject-toml-rs#24 is good reference implementation, we can reuse it.
There was a problem hiding this comment.
I'll add support for the include-group syntax separately. This just copies our existing patterns.
I can hold of on merging though since it'd break people using the syntax.
There was a problem hiding this comment.
Honestly pretty hesitant to change the pattern here? We probably want to change all the structures separately if you want a different approach.
There was a problem hiding this comment.
We're using both styles in uv, it's not that much of a difference in the end
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
Part of #8090 As a basic first step, we parse these groups defined in `pyproject.toml` files.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
Part of #8090 As a basic first step, we parse these groups defined in `pyproject.toml` files.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 As a basic first step, we parse these groups defined in `pyproject.toml` files.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 As a basic first step, we parse these groups defined in `pyproject.toml` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8090
As a basic first step, we parse these groups defined in
pyproject.tomlfiles.