ci: Make Windows tests ~27% faster by putting temp folder in dev drive #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0a9f6e.
…the wrong log filter kicking in
fasterthanlime
force-pushed
the
ci-tests
branch
from
67ac298
to
66d5e2d
Compare
fasterthanlime
changed the title
fasterthanlime
changed the title
|
@fasterthanlime Curious, it seems
Would this have work if |
fasterthanlime
added a commit
to bearcove/uv
that referenced
this pull request
Aug 30, 2024
As suggested by @samypr100 on astral-sh#6680: astral-sh#6680 (comment)
fasterthanlime
added a commit
to bearcove/uv
that referenced
this pull request
Aug 30, 2024
As suggested by @samypr100 on astral-sh#6680: astral-sh#6680 (comment)
charliermarsh
pushed a commit
that referenced
this pull request
Aug 30, 2024
…6858) As suggested by @samypr100 on #6680: #6680 (comment) ## Summary Instead of using `UV_INTERNAL__TEST_DIR`, it simply exports `TEMP` when running Windows jobs. ## Test Plan I'm going to run this manually under ProcMon on my Windows machine and see where uv writes temp files, hopefully to the dev drive and not `%(LOCAL)APPDATA%` or something. I'm going to commit a dummy code change and look at build time changes in CI.
|
Part of #5713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
cargo test | windowsfaster in CI.Before
After
Also
This PR disables the
brotlifeature ofasync-compressionsince it's not strictly needed, but this has little to do with the improvements (it's still less code to build).This PR introduces additional code in uv tool uninstall to ignore errors (that only seem to happen on ReFS, ie. on Dev Drives) akin to "the thing we're trying to delete cannot be deleted because it's already being deleted".
If
raw_os_errorwas stable we could do u32 matching instead of that.to_string().contains()abomination.