Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream konstin/pep508_rs#17 #6200

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Upstream konstin/pep508_rs#17 #6200

merged 1 commit into from
Aug 19, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Aug 19, 2024

Upstream konstin/pep508_rs#17

This removes the derivative dependency which seems to be unmaintained and depends on old versions of some crates, especially syn.

I could also replace it with another crate like educe or derive-where but the implementation seems simple enough.

Upstream konstin/pep508_rs#17

> This removes the `derivative` dependency which [seems to be unmaintained](mcarton/rust-derivative#117) and depends on old versions of some crates, especially `syn`.
>
> I could also replace it with another crate like `educe` or `derive-where` but the implementation seems simple enough.
@konstin konstin added the internal A refactor or improvement that is not user-facing label Aug 19, 2024
@konstin konstin enabled auto-merge (squash) August 19, 2024 11:24
@konstin konstin merged commit 4469f57 into main Aug 19, 2024
55 of 56 checks passed
@konstin konstin deleted the konsti/upstream-pep508-17 branch August 19, 2024 11:31
BurntSushi added a commit that referenced this pull request Aug 19, 2024
This seems to be failing the `cargo shear` check on `main`. It looks
like this was caused by #6200.
BurntSushi added a commit that referenced this pull request Aug 19, 2024
This seems to be failing the `cargo shear` check on `main`. It looks
like this was caused by #6200.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant