Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a larger runner for Windows test jobs #5873

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Use a larger runner for Windows test jobs #5873

merged 1 commit into from
Aug 7, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 7, 2024 •
edited
Loading

From 8 to 16 cores, 32 to 64 GB ram. Testing on Windows first because it's the bottleneck.

Previously tested in #2515 to no effect, maybe better now that we have a development drive?

@zanieb zanieb added the testing Internal testing of behavior label Aug 7, 2024
@zanieb
Use a larger runner for Windows test jobs
9ff8846 
From 8 to 16 cores, 32 to 64 GB ram
@zanieb
Copy link
Member Author

zanieb commented Aug 7, 2024 •
edited
Loading

From 9m 21s to 6m 17s, nearly entirely in the cargo test step. The runner is twice as expensive, moving from $0.064 to $0.128 per minute. Since we've saving time, it'll be less than 2x expensive, but still more costly. Seems very worth it.

Note that 9m is one of the jobs on main, we've seen times as low as 7m.

@zanieb zanieb marked this pull request as ready for review August 7, 2024 16:39
@zanieb zanieb mentioned this pull request Aug 7, 2024
Merged
@zanieb zanieb merged commit 8dad1ac into main Aug 7, 2024
57 checks passed
@zanieb zanieb deleted the zb/windows-larger-runner branch August 7, 2024 17:32
zanieb added a commit that referenced this pull request Aug 7, 2024
@zanieb
Use a larger runner for macOS test jobs (#5874)
c77f213 
From 3 to 6 (+8 GPU) cores, 7 to 14 GB ram.

Related:
- #5873
@zanieb zanieb mentioned this pull request Aug 7, 2024
Merged
zanieb added a commit that referenced this pull request Aug 7, 2024
@zanieb
Use a larger runner for Linux test jobs (#5883)
858d75d 
From 8 to 16 cores, 32 to 64 GB RAM for a 2x per minute cost increase.

As in:

- #5874 
- #5873
This was referenced Aug 7, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
testing Internal testing of behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zanieb