Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not treat interpereters discovered via CONDA_PREFIX as system interpreters #3771

Merged
merged 2 commits into from
May 22, 2024
Merged

Do not treat interpereters discovered via CONDA_PREFIX as system interpreters #3771

merged 2 commits into from
May 22, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented May 22, 2024 •
edited
Loading

Closes #3769

@zanieb zanieb added the bug Something isn't working label May 22, 2024
@zanieb zanieb changed the title zb/conda prefix Do not treat interpereters discovered via CONDA_PREFIX as system interpreters May 22, 2024
@zanieb zanieb mentioned this pull request May 22, 2024
Closed
@zanieb zanieb mentioned this pull request May 22, 2024
Closed
@zanieb zanieb marked this pull request as ready for review May 22, 2024 20:48
@zanieb zanieb mentioned this pull request May 22, 2024
Merged
@zanieb
Copy link
Member Author

zanieb commented May 22, 2024

This is passing an integration test at #3773 and I'd like to get the fix out now.

I've opted not to allow VIRTUAL_ENV to point to a system Python installation anymore as described in #3765 so I think this is the right level of change.

@zanieb zanieb merged commit 87b73ef into main May 22, 2024
44 checks passed
@zanieb zanieb deleted the zb/conda-prefix branch May 22, 2024 21:27
zanieb added a commit that referenced this pull request May 22, 2024
@zanieb
Add test case for Conda CI (#3773)
17ec349 
Integration test coverage for #3769 

Failure against `main` on
https://github.com/astral-sh/uv/actions/runs/9198224186/job/25300510016?pr=3773

Rebased against #3771 to check for fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uv 0.2.0 no longer working inside conda environments
1 participant
@zanieb