Use Depot for Windows cargo test
#14122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samypr100
reviewed
Jun 18, 2025
Comment on lines
+17
to
+18
| # so we must check if it's a Depot runner first, and we use `V:` as the target | ||
| # instead. |
Collaborator
There was a problem hiding this comment.
we use
V:as the target instead.
Nice 😆
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Jun 18, 2025
From 6m 15s -> 3m 54s (total runtime) See also astral-sh/uv#14122 We don't use a Dev Drive here so this is trivial (ref #15664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #12320
Switches to Depot for the large Windows runner we use for
cargo test.The runtime goes from 8m 20s -> 6m 44s (total) and 7m 18s -> 4m 41s (test run) which are 20% and 35% speedups respectively.
A few things got marginally slower, like Python installs went from 11s -> 38s, the Rust cache went from 15s -> 30s, and drive setup went from 7s -> 20s.