Fix tests due to yanked configargparse #13623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release of configargparse locked in the tests was yanked, we fix this by updating the snapshots.
charliermarsh
approved these changes
May 23, 2025
|
If it gets unyanked, would we need to update again? |
|
As I understood it, yanking is intended as a final action, with users migrating either to the previous release, if the new release was accidental, or to the next release, if the problem was fixed there. configargparse made the new 1.7.1 release to replace the broken 1.7 (bw2/ConfigArgParse#300 (comment):
Regular users can update to that release, but due to our exclude newer test filter, we have to downgrade to the older version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of configargparse locked in the tests was yanked, we fix this by updating the snapshots.