make snapshot test more permissive #13251
Conversation
| r#""commits_since_last_tag": .*"#, | ||
| r#""commits_since_last_tag": [COUNT]"#, | ||
| ), | ||
| // This last filter normalizes output for tarball builds of uv that lack commit info |
There was a problem hiding this comment.
Given this test won't really change a lot, should we just check if commit info is available and have two snapshots? Using filters this way makes me a bit uncomfortable.
There was a problem hiding this comment.
oh interesting, i never considered conditional snapshots! that's a great idea
There was a problem hiding this comment.
They're just annoying during snapshot updates, so I try to avoid them in most cases.
There was a problem hiding this comment.
but if the filter is replacing basically the entire expected output, I'd either just skip the test or have a conditional.
There was a problem hiding this comment.
I've filed #13566 doing that.
|
Gentle ping. Can I do anything to help move this or any other solution forward? |
Fix the two version json tests to account for the possibility that uv was built outside a git checkout (e.g. from an unpacked git archive) and therefore does not have the commit info available. This approach uses separate snapshots for the two cases, as suggested in discussion of pull request astral-sh#13251. Fixes astral-sh#13212
## Summary Fix the two version json tests to account for the possibility that uv was built outside a git checkout (e.g. from an unpacked git archive) and therefore does not have the commit info available. This approach uses separate snapshots for the two cases, as suggested in discussion of pull request #13251. Fixes #13212 ## Test Plan 1. `cargo test` in a git clone. 2. `cargo clean`, moved `.git` away, `cargo test` again. --------- Co-authored-by: Aria Desires <aria.desires@gmail.com>
fixes #13212